V4.6.0 smoke testing

Hi folks,

I’d like to have some smoke testing before releasing v4.6.0 which has the following changes, as some features may affect the other features:

New feature

  • Support unsetting a tag from multiple notes at once (Thanks Halloleo)
  • Support YAML frontmatter (Experimental)

Improvement

  • Blur before hiding the main window (Thanks Jasper)
  • Support selectFirstNote option in the following commands:
    • core:note-list-show-all-notes
    • core:note-list-show-notes-in-book
    • core:note-list-show-notes-with-tag
    • core:note-list-show-notes-with-status
  • Show plugin version number in Preference window (Thanks Sceptic)
  • Add “All Files” filter on import dialog (Thanks Nicole)
  • Update Electron to 7.1.13
  • Window won’t show when logged out
  • Handle anchor links in preview
  • Load CodeMirror language mode on demand
  • Highlight codeblocks in plugin readme

Bugfix

  • Some image attachments are not properly backed up
  • Insert " " between text token in note list view item (Thanks Koike-san)
  • (API) Babel configuration broken (Thanks Prescott and Jasper)
    • Now it uses core-js@3 properly, so you don’t need to add core-js@2 as your plugin dependency
    • The recent Electron does support the most of ES6 features like Object Spread without using Babel
  • (API) Should respect dismissable parameter of Notification Manager (Thanks Jasper)

Download

@Yuko_Otawara, @jmerle, @Prescott_Murphy, @Nicole_Daniella,
Could you help me check if it works without any big regressions?
Thanks in advance!

1 Like

I’ll do some testing on Windows 10 and Ubuntu 18.04 after work today (in about ~9 hours).

Thanks!

Things seemed good on macOS after some quick testing. Using ES6 syntax without explicit dependency on coreJS@3 in a plugin also didn’t blow up like it did previously!

Windows 10:

Everything works well, all my plugins work as expected and I can’t seem to break anything.

Ubuntu 18.04:

Doesn’t work, it seems to require glibc 2.28 while Ubuntu 18.04 is limited to 2.27 (libc6 == glibc):

$ ./inkdrop
[bugsnag] Loaded!
[bugsnag] Uncaught exception, the process will now terminate…
Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/.org.chromium.Chromium.irRvX5)
    at process.func (electron/js2c/asar.js:140:31)
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:922:18)
    at Object.func (electron/js2c/asar.js:140:31)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)
    at Module.require (internal/modules/cjs/loader.js:775:19)

Thank you for your help, @Prescott_Murphy and @jmerle!
Good to hear that it works well except for the Linux build.
I rebuilt it, so could you try it again?

https://inkdrop-dist.s3-ap-northeast-1.amazonaws.com/v4.6.0/Inkdrop-4.6.0-Linux.zip

I checked that it doesn’t require GLIBC_2.28 with a command:

objdump -T /tmp/.org.chromium.Chromium.* | grep GLIBC | sed -n 's/.*\(GLIBC_[0-9]\.[0-9]\+\).*$/\1/p' | sort -V | tail -n 1
GLIBC_2.14

The rebuilt version works without problems, same behavior as on Windows 10.

1 Like

Thanks a lot!
will roll it out :muscle:

Sorry for the delayed response, all good from my end, didn’t have any issues starting it up and importing files.

1 Like

Thank you for checking, Nicole!

I apologize ahead of time for replying in Japanese.


確認が遅れてすみません!
こちらの環境でも特に問題はなさそうです。
アップデートお疲れさまでした :smile:

1 Like