Unable to upload photo on iOS

Ryan_McQuen · March 9, 2021, 9:31pm

Bug report

I cannot upload a photo from the library or a taken photo in Inkdrop. After I do the app becomes completely unresponsive and I have to close the app to continue using it. I have tried uninstalling and reinstalling the app.

Info

Platform: iOS
Platform version: 14.4.1
App Version: 4.1.0

Reproduce

craftzdog · March 10, 2021, 5:18am

Hi Ryan,

Thank you for the report.
That’s weird. I tried to reproduce it on my iPhone 11 Pro and iPod touch (7th gen) but it works fine.
It could be a device-dependent issue but I’m not sure why at the moment.

Ryan_McQuen · March 10, 2021, 5:37am

This is an iPhone SE (2020).

craftzdog · March 10, 2021, 5:46am

It could be react-native-image-picker’s issue but I couldn’t find any related issues.
Let me know if you find anything.

Ryan_McQuen · March 10, 2021, 5:55am

This?

craftzdog · March 10, 2021, 5:57am

No, I guess that’s not a bug.

Ryan_McQuen · March 10, 2021, 3:40pm

I think it is related to these new photo permissions:

Other apps prompted me about them but Inkdrop never does.

craftzdog · March 11, 2021, 9:24am

That’s the permission to import the existing photos.
As you can launch the camera, you should have sufficient permission like so:

craftzdog · March 11, 2021, 9:42am

Oh, but Instagram has “Photos” permission:

Interesting. I’ll look into it.

craftzdog · March 15, 2021, 3:17am

@anon74459912 also reported the same issue.
Interestingly, his phone is also iPhone SE.
I’ll try to reproduce it on an iPhone SE simulator.

craftzdog · March 15, 2021, 6:20am

Couldn’t reproduce it on the iPhone SE simulator.
UIImagePickerController basically doesn’t require permission to import images, as you could already select an image / take a photo.
I also tried to reinstall the app but it successfully inserted an image on my iPhone 11 Pro (iOS 14.4.1 - latest).
It’s mysterious.

anon74459912 · March 15, 2021, 8:08am

I encountered similar issues on iOS14 with an app I develop for a client related to the new PHPickerController. I look into it and may share what was problem there and how we fixed it.

My iOS Settings for Inkdrop look like this ->

Although the camera option appears, I can take one, but it wont appear in the note and from that moment on, the app just get stuck in this node and the editing mode and I have to kill and restart the app.

For other apps there appear also the Photos Icon and options. For Photos I’d choose “selected images” in those apps.

Ryan_McQuen · March 15, 2021, 11:07am

I wonder if these are some kind of inherited ‘ghost’ permissions. I think my phone has never had an iOS earlier than 14.x.

Is there a way to explicitly add/ask for ‘Photos’ permission?

anon74459912 · March 15, 2021, 5:49pm

since the introduction of iOS14 and its new privacy options, apple recommends to use the PHPickerController and let users select the single images the app can access. Thereby there is no need for the app to ask for any permissions https://developer.apple.com/videos/play/wwdc2020/10652/

But it seems to have some bugs or at least some pitfalls for developers implementing it.

craftzdog · March 16, 2021, 5:12am

Thanks for the info.
Maybe I need to tweak react-native-image-picker to use PHPickerController.

anon74459912 · March 17, 2021, 9:32am

I’m interested how it will work out for you. In my company we encountered similar problems with Flutter. Maybe your experience with this iOS-API is helpful.

anyway, I would recommend watching the two WWDC sessions on this topic. Maybe you can solve it another way.

craftzdog · March 19, 2021, 2:24am

Well, I changed the following code for the image picker to always ask for photos permissions:

github.com

react-native-image-picker/react-native-image-picker/blob/main/ios/ImagePickerManager.m#L270


        callback(YES);
    };

    if (target == camera && [self.options[@"saveToPhotos"] boolValue]) {
        [self checkCameraAndPhotoPermission:permissionBlock];
    }
    else if (target == camera) {
        [self checkCameraPermissions:permissionBlock];
    }
    else {
        if (@available(iOS 11.0, *)) {
            callback(YES);
        } else {
            [self checkPhotosPermissions:permissionBlock];
        }
    }
}

- (NSString*) getImageFileName:(NSString*)fileType {
    NSString *fileName = [[NSUUID UUID] UUIDString];
    fileName = [fileName stringByAppendingString:@"."];

I’ll let you know when published it on TestFlight.

craftzdog · March 20, 2021, 2:19am

Published it on TestFlight. Could you try it? @anon74459912 @Ryan_McQuen

anon74459912 · March 20, 2021, 2:35pm

Hi, thank you for the TestFlight link!
So, that’s super weird.
The Problem stays the same: I can not add an image from my photo library (even if I picked one or granted every permission) nor can add one from the camera app.
But after I added an image from my computer in the same note and only thereafter I was able to add images in that particular note and the entire iOS app. Since then, I can add as much images and photos in any old or new note inside the App (the TestFlight Version).

anon74459912 · March 20, 2021, 2:40pm

I reinstalled the version from the AppStore and it now works. I really don’t know what did cause the initial problem. The app now don’t has any permissions, except for the camera app and the selected images