Enable codefold

Features & ideas
21

Hi Samantha,

Hm, it looks nice but I guess the command name should be codefold:fold-all / codefold:unfold-all.
Maybe export-print plugin would be helpful as an example.

I think the command is only triggered while you are on the editor, so it’d be better if selectors for keymaps are like:

{
  ".platform-darwin .CodeMirror": {
    "cmd-r": "codefold:fold-all",
    "cmd-t": "codefold:unfold-all"
  },
  ".platform-linux .CodeMirror": {
    "ctrl-r": "codefold:fold-all",
    "ctrl-t": "codefold:unfold-all"
  },
  ".platform-win32 .CodeMirror": {
    "ctrl-r": "codefold:fold-all",
    "ctrl-t": "codefold:unfold-all"
  }
}

And I guess cmd-r and cmd-t are kind of too general key combination because it’s often used for reloading, running, compiling, tabs, etc.
So other key combination would be nice like cmd-shift-o / cmd-shift-u.

Hope that helps!

22

Made an update: https://github.com/moyicat/inkdrop-code-fold/commit/e7f1d9cbe356a1eafebf7a3c9c31c71581abc805

But I’m still not seeing keymap here:

19%20PM
Screen Shot 2018-07-19 at 3.09.19 PM.png952×712 51.6 KB

23

Hi,

Thanks for the information.
I tried your plugin and found that keybindings are correctly loaded:

47
Screen Shot 2018-07-20 at 10.09.47.png1904×1424 234 KB

But there are two problems.

First, you should name commands starting with code-fold: which is your exact plugin name. Because the app tries to find commands that start with "<your plugin name>:" on your plugin detail screen. So please rename from codefold:fold-all to code-fold:fold-all.

Second, I found a bug that keybindings on the plugin screen doesn’t show them correctly if a selector has a platform. I’ll fix it in the next release!

Thanks again.

24

Gotcha! Updated and published a new version :slight_smile:

1 Like
25

Great! And v3.20.2 has resolved the second issue. Thanks again!

26

It’s cool plugin! Thanks!

27

This plugin seems not to work anymore.

28

Unfortunately, Samantha isn’t active with maintaining the plugin at the moment.

Would you be interested in taking over it?

29

Good day Takuya!

Unfortunately, I already commited to doing @anon20920130 Toolbar plugin first.

Perhaps maybe I can just combine the two ideas by putting in a code “fold all/unfold all” button on the toolbar plugin as a future update once the developer licenses are open again.

1 Like