Validation error should be displayed as human-friendly message

Samantha_Zhang · July 7, 2020, 12:06am

Bug report

Trying to create a note with the title “Design isn’t crafting a beautiful textured button with breathtaking animation. It’s figuring out if there’s a way to get rid of the button altogether.” and getting the bug report at the end.

Shortening the title fixed it.

Info

Platform: Windows 10
App Version: (4.6.1)
Plugins: I have 10+ of them, but because shortening the title worked for me, I think it’s not related to plugins.

Debug Info

Error: Could not call remote method 'put'. Check that the method signature is correct. Underlying error: Invalid note document
Underlying stack: Error: Invalid note document
    at t.default.put (C:\Users\moyi\AppData\Local\inkdrop\app-4.6.1\resources\app.asar\main.js:1:46511)
    at electron/js2c/browser_init.js:6651:63
    at EventEmitter.<anonymous> (electron/js2c/browser_init.js:6504:21)
    at EventEmitter.emit (events.js:203:13)
    at EventEmitter.emit (domain.js:476:20)
    at WebContents.<anonymous> (electron/js2c/browser_init.js:3871:23)
    at WebContents.emit (events.js:203:13)
    at WebContents.EventEmitter.emit (domain.js:476:20)
    at WebContents.topLevelDomainCallback (domain.js:131:23)

at electron/js2c/browser_init.js:6653:17
at EventEmitter.<anonymous> (electron/js2c/browser_init.js:6504:21)
at EventEmitter.emit (events.js:203:13)
at EventEmitter.emit (domain.js:476:20)
at WebContents.<anonymous> (electron/js2c/browser_init.js:3871:23)
at WebContents.emit (events.js:203:13)
at WebContents.EventEmitter.emit (domain.js:476:20)
at WebContents.topLevelDomainCallback (domain.js:131:23)

craftzdog · July 7, 2020, 6:01am

Hi Samantha,

Thank you for reporting it.
That’s an intended behavior as note title’s max length is 128:

github.com

inkdropapp/inkdrop-model/blob/master/yaml-schema/note.yaml#L27


  example: 14-813af5085bb6a2648c3f0aca37fc821f
bookId:
  description: 'The notebook ID'
  type: string
  minLength: 5
  maxLength: 128
  pattern: '^(book:|trash$)'
title:
  description: 'The note title'
  type: string
  maxLength: 128
doctype:
  description: 'The format type of the body field. It currently can take markdown only, reserved for the future'
  type: string
  enum:
    - markdown
body:
  description: 'The content of the note represented with Markdown'
  type: string
  maxLength: 1048576
updatedAt:

But looks like the app should display more human-friendly error

craftzdog · July 27, 2020, 6:39am

improved the error message in v5.0.0-beta.1!