React error when i deactive my plugin in dev

lofidev · April 13, 2022, 8:14am

Hello, I am developing a plugin and it is already as I want it, I only have one problem and it is when I deactivate the plugin I get the following error. Any idea what’s going on?

this happens when i go to preview

My code:

Edit:
Link-card give me the same problem, maybe is only my case
https://my.inkdrop.app/plugins/link-card

craftzdog · April 14, 2022, 12:30am

Hi lofidev,

That looks cool.
I’ve tried to reproduce it but it successfully gets deactivated.
I guess another plugin is causing that? I see some plugins are not deactivating properly.

craftzdog · April 14, 2022, 12:33am

btw, I thought I have to write a codeblock after seeing this example:

CleanShot 2022-04-14 at 09.30.54@2x

But the backticks are not necessary for the plugin.
Maybe you want to remove them.

craftzdog · April 14, 2022, 1:18am

Got it to reproduce.
So, the error is:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined.

That is caused by this line:

github.com

jpastorm/inkdrop-alert/blob/master/lib/inkdrop-alert.js#L22

    
      
                const origP = markdownRenderer.remarkReactComponents.p;
                const cardAlert = createCardAlert(origP);
                markdownRenderer.remarkReactComponents.p = cardAlert;
                this.origPComponent = origP;
              }
            },
          
          
  deactivate() {
              inkdrop.components.deleteClass(createCardAlert);
              if (markdownRenderer) {
                markdownRenderer.remarkReactComponents.p = this.origPComponent;
              }
            },
          };

Because the original P component can be undefined.
You should unset the p property instead if it was undefined something like:

if (this.origPComponent !== undefined) {
  markdownRenderer.remarkReactComponents.p = this.origPComponent;
} else {
  delete markdownRenderer.remarkReactComponents.p;
}

lofidev · April 14, 2022, 9:23am

Thanks @craftzdog, solution works perfectly.
I published my plugin, but i have a problem with version.

https://my.inkdrop.app/plugins/alert-area

i cant change the plugin version with the command
ipm publish --tag v0.1.0
currently the plugin can be downloaded because I added a v0.0.0 tag on my github

craftzdog · April 15, 2022, 12:36am

Awesome!
Can you try incrementing the version number like so?

ipm publish [patch | minor | major]

lofidev · April 15, 2022, 11:07pm

For some reason it doesn’t work for me, I don’t know if the error affects the publish

chanakan5591 · April 16, 2022, 12:26am

the deprecation warning is just a warning and shouldn’t matter because I can still also publish the packages as usual.

craftzdog · April 18, 2022, 3:06am

yea that’s nothing to do with plugins themselves.
I guess that’s because the tag v0.1.0 already exists.

lofidev · April 18, 2022, 3:23pm

I’ve been trying but I still couldn’t, the steps I followed are the following:

Create a git tag v0.8.0 (this is a tag that I never create)
Command : git tag v0.8.0
Push tag to github
command : git push --tags
At this point my package.json already had version v0.7.0, so running the command ipm publish minor i pushed the new tag
Pushing v0.8.0 tag

I’m sorry for the inconvenience and your wasted time , I think I’m doing something wrong and I hope it won’t be repeated in other projects I have in mind.

chanakan5591 · April 18, 2022, 10:24pm

The git tag would automatically be created by ipm tool. So you shouldn’t need to manually create it via git, that might be the cause of ipm failing.

craftzdog · April 19, 2022, 7:07am

Yes, ipm does that automatically.