Need help updating plugin


(Samantha Zhang) #1

Hey Takuya,

Trying to update my two plugins to support v4 but got some issues:

img-small

The change is really simple. But I got this error when I try to publish the change:

$ ipm publish patch
Preparing and tagging a new version ✓
Pushing v1.0.2 tag ✓
Publishing img-small@v1.0.2 ✗
Creating new version failed: You don't have access to that package

code-fold

This is more complicated. I made the editor.codeMirror to editor.cm change as suggested, but getting this error:

Type Error: global.inkdrop.on is not a function

Help please, thanks a lot!


(Takuya Matsuyama) #2

Hi Samantha,

Great to know that you are trying to update your plugins!

img-small

ipm now uses credentials from Inkdrop’s keychain instead of API keys.
Did you log in to inkdrop on a computer where you run ipm?
If so, can you please tell me your platform?

code-fold

I added a section for that!

You can call it instead like so:

global.inkdrop.onEditorLoad(this.handleEditorInit.bind(this));

Cheers!


(Takuya Matsuyama) #3

This is a bug which resides on the API server. Will fix it!

Creating new version failed: You don't have access to that package

(Takuya Matsuyama) #4

It was a wrong HTTP header issue.
Can you please try ipm of this patch?

https://inkdrop-dist.s3-ap-northeast-1.amazonaws.com/tmp/Inkdrop-4.0.1-beta.1-Mac-patch-1.zip

Thanks!


(Samantha Zhang) #5

Thanks Takuya! The img-small plugin is published!

However, the code fold isn’t working correctly yet.

I made this commit: https://github.com/moyicat/inkdrop-code-fold/commit/6ef1b0f79234d4f880eee32308772493c1e6ed16

And looks like cm is getting the correct setting:

00%20AM

But it’s not taking effect.

Can you help check it out? Thanks!


(Takuya Matsuyama) #6

Great! :raised_hands:

I checked code-fold out and found that it works fine.

26

Maybe you are loading the old version?


(Samantha Zhang) #7

lol worse–I was testing on a note that has bullet points but not # titles :joy: problem solved and published. Thanks Takuya!


(Takuya Matsuyama) #8

haha, you’re welcome! Congrats :tada: