Keybindings with numbers and the shift modifier together do not work

Lukas · March 12, 2024, 8:58pm

I have checked the troubleshooting

Bug report

Currently keybindings cannot contain numbers with the shift modifier together in one keybinding (eg. ctrl-shift-2)

Therefore the default keybindings for changing the note status also dont work.

I have tried to use the character in the keybinding that appears when using shift and the number (eg. shift-1 → ! - german keyboard layout) as this is the case when using the shift modifier with an alphabetic character (eg. shift-K)

Environment

Platform: Windows, Ubuntu
Platform version: 11, 22.04
App Version: v5.8.0-beta.1

How to reproduce

These are a few keybindings that i have used for some testing.

not working keybindings:

"alt-shift-2"
"ctrl-shift-2"
"shift-ctrl-2"
"ctrl-shift-!"
"shift-ctrl-!"

craftzdog · March 13, 2024, 1:12am

Hi Lukas,

Thanks for the report.
I looked into the source code of the Atom’s keymap module and found that it is intended:

github.com

inkdropapp/inkdrop-keymap/blob/e7bdc852a554a7e18d01610b67fa6bbced917f95/src/helpers.js#L347


      
                  // fetch the shifted version to maintain our former keystroke output
                } else if (!isAltModifiedKey) {
                  return __guard__(
                    KeyboardLayout.getCurrentKeymap(),
                    x1 => x1[event.code]
                  )
                }
              })()
          
            if (characters) {
              if (event.shiftKey) {
                key = characters.withShift
              } else if (characters.unmodified != null) {
                key = characters.unmodified
              }
            }
          }
          
          // Work around https://bugs.chromium.org/p/chromium/issues/detail?id=766800
          // TODO: Remove this workaround when we are using an Electron version based on chrome M62
          if (

It converts characters to the ‘with-shift’ ones if the shift key is held down.

But I guess it could be resolved by converting characters when normalizing a keystroke here:

github.com

inkdropapp/inkdrop-keymap/blob/e7bdc852a554a7e18d01610b67fa6bbced917f95/src/helpers.js#L146


      
          }
          
          if (keyup) {
            if (primaryKey != null) {
              primaryKey = primaryKey.toLowerCase()
            }
          } else {
            if (isUpperCaseCharacter(primaryKey)) {
              modifiers.add('shift')
            }
            if (modifiers.has('shift') && isLowerCaseCharacter(primaryKey)) {
              primaryKey = primaryKey.toUpperCase()
            }
          }
          
          keystroke = []
          if (!keyup || (keyup && primaryKey == null)) {
            if (modifiers.has('ctrl')) {
              keystroke.push('ctrl')
            }
            if (modifiers.has('alt')) {

I’ll try it.

craftzdog · March 13, 2024, 5:08am

Can you try this patch?

https://inkdrop-dist.s3.ap-northeast-1.amazonaws.com/tmp/Inkdrop-5.8.0-beta.1-Windows_match1.zip

Lukas · March 13, 2024, 4:49pm

Thanks, it looks like it works with the patch.
I have tried this successfully with the following keybindings:

ctrl-shift-1
ctrl-shift-3
alt-shift-1
alt-shift-3

craftzdog · March 14, 2024, 12:06am

Great! Thanks for testing.