It maximizes when recover it from the task tray

avis · September 2, 2021, 1:36pm

Bug report

It always maximizes when I recover the window from the task tray.
The same is true if I run ‘Show Inkdrop’ on the task tray icon.

When I pressed the minimize button, it seemed to maximize and then hide.

Info

Platform: (Windows)
Platform version: (10)
App Version: (5.4.0)

Reproduce

Minimize the Inkdrop window.
Click on the icon in the task tray.
Inkdrop will always recover in maximized mode.

craftzdog · September 3, 2021, 1:37am

Hi Avis,

Thank you for the report.
That’s weird. I tried to reproduce it but couldn’t.
It properly restores the window without maximizing.
In terms of implementation, it just calls BrowserWindow#minimize, so it shouldn’t maximize.

craftzdog · September 3, 2021, 1:52am

Ah, you are talking about the tray plugin, which is a community-made plugin.
@jmerle Can you please look into it?

avis · September 3, 2021, 1:56am

Oh, sorry about that…
It seems to be a problem with the tray plugin.

craftzdog · September 3, 2021, 1:59am

I guess this line would be causing the problem:

github.com

jmerle/inkdrop-tray/blob/master/src/index.js#L43


    {
      label: 'Quit',
      click: () => remote.app.quit(),
    },
  ]);
}
function onMinimize() {
  if (inkdrop.config.get('tray.minimizeToTray')) {
    if (inkdrop.clientInfo.clientName === 'win32') {
      inkdrop.window.maximize();
      inkdrop.window.blur();
    }
    inkdrop.window.hide();
  }
}
export const config = {
  minimizeToTray: {
    title: 'Minimize to tray',

jmerle · September 5, 2021, 2:34pm

Hi Avis,

I just released a new version of the Tray plugin that should fix the issue. Can you try updating the Tray plugin to v1.3.0 by going to Preferences > Plugins > Updates and see if the issue is gone?

avis · September 8, 2021, 2:12am

@craftzdog @jmerle
Thanks for the great support !
The Tray plugin v1.3.0 is working perfectly on my Inkdrop v5.4.1.

craftzdog · September 8, 2021, 2:16am

Great!