Embed a vimeo external content to note

Bundit_Jianpinitnan · March 7, 2023, 1:45pm

Hello Takuya,

Refer to this embed plugin, and this PR, that’d be good if considering to extend this plugin on a vimeo. I truly understand what you’ve raised the limitation of external contents for printing/exporting and searching.

Best regards,
Bundit

craftzdog · March 8, 2023, 6:04am

Hi Bundit,

Yeah that is nice to have.
Created an issue on the repo:

I guess it can be easily supported just like YouTube:

github.com

inkdropapp/inkdrop-embed/blob/master/src/providers/youtube.js

import * as React from 'react'
import { useRef, useState } from 'react'
const BASE_URL = 'https://www.youtube.com/'
const EMBED_PROVIDER_URL = 'https://www.youtube.com/embed/'

export function test(url) {
  return url.startsWith(BASE_URL)
}

export default function YouTube(props) {
  const { href } = props
  const contentFrame = useRef()
  const [frameId] = useState('youtube-' + Math.random())
  const query = new URLSearchParams(href.split('?')[1])
  const videoId = query.get('v')
  const url = `${EMBED_PROVIDER_URL}${videoId}`

  return (
    <iframe
      id={frameId}

This file has been truncated. show original

Feel free to send me a pull request if you have time

NotApplicable · March 17, 2023, 11:22pm

Addition was quite simple, thought I would add it in real quick: feat(embed): added vimeo provider by 0NotApplicable0 · Pull Request #10 · inkdropapp/inkdrop-embed · GitHub

Msg if you need anything changed.

craftzdog · March 20, 2023, 12:35am

Great work, @NotApplicable

craftzdog · April 4, 2023, 1:10am

Published!