App crashes when showing error dialog

Bug report

Write the description of the issue here.
If you got a problem, please check if you got any error in the console log by selecting the menu: Developer -> Toggle Developer Tools.

If you report an issue about a plugin, please check the author of the plugin:

  • If it’s a third-party plugin, report it on the GitHub Issue
  • If it’s an official plugin, report here
  • Make sure you are using the latest version of the plugin. You can update it with ipm update.

Info

  • Platform: macOS
  • Platform version: Catalina 10.15.3
  • App Version: 4.6.0

Reproduce

I drag a gif file into a note and receive “Sorry, app crashed”:

TypeError: $(...).accordion is not a function
    at f.showDialog (file:///Applications/Inkdrop.app/Contents/Resources/app.asar/browser-main.js:4:82489)
    at f.componentDidUpdate (file:///Applications/Inkdrop.app/Contents/Resources/app.asar/browser-main.js:4:81327)
    at ik (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:251:463)
    at exports.unstable_runWithPriority (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/scheduler/cjs/scheduler.production.min.js:18:437)
    at fg (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:120:325)
    at Yj (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:244:437)
    at Lj (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:223:420)
    at /Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:121:115
    at exports.unstable_runWithPriority (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/scheduler/cjs/scheduler.production.min.js:18:437)
    at fg (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:120:325)
    at ig (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:121:61)
    at jg (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:120:496)
    at bk (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:224:156)
    at Object.notify (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-redux/lib/utils/Subscription.js:29:7)
    at Subscription.notifyNestedSubs (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-redux/lib/utils/Subscription.js:71:20)
    at Subscription.handleChangeWrapper (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/react-redux/lib/utils/Subscription.js:76:12)
    at dispatch (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/redux/lib/redux.js:228:7)
    at /Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/redux-thunk/lib/index.js:14:16
    at Object.dispatch (file:///Applications/Inkdrop.app/Contents/Resources/app.asar/browser-main.js:4:381178)
    at file:///Applications/Inkdrop.app/Contents/Resources/app.asar/browser-main.js:4:27512
    at __trace__ (/Applications/Inkdrop.app/Contents/Resources/app.asar/node_modules/@bugsnag/browser/plugin-inline-script-content/inline-script-content.js:138:30)

Hi Prescott,

Thank you for reporting it.
Seems like you added a gif file which is too large.
The app tried to show an error dialog but crashed due to the change in the latest version.
Will fix it!

Fixed it. It should show up an error dialog as expected. Could you check just in case?

https://inkdrop-dist.s3-ap-northeast-1.amazonaws.com/v4.6.1/Inkdrop-4.6.1-Mac.zip

Thanks!

Works now:

1 Like

Great!

Thanks for getting this update out so quickly! :raised_hands:

High five🙌 Thanks again for reporting, as always!

Landed in v4.6.1 :tada: