Snap package out of date?

John_Feminella · June 14, 2019, 3:22am

The Snap package seems very out of date (it’s still on Inkdrop 3). Is there an update planned?

Reproduce

Visit https://snapcraft.io/inkdrop.
Download.
Version 3.25.4 is downloaded, which is far behind version 4.

Daniel_Hill · June 14, 2019, 7:02pm

+1 would like to see the snap kept up to date.

craftzdog · June 19, 2019, 4:42am

Thanks for the report.

Yes, I gave up providing the snap package for Inkdrop.
Because it often fails to build for various reasons, and lack of information to fix them.
Here is the snapcraft repository:

I would really appreciate if you could help me build it!

John_Ferlito · November 10, 2019, 2:20am

Hi!

Are you using electron-builder to build tha app?
It now has integrated snap support

Let me know if you can switch to this. Otherwise I’ll spend some time on the repo above.

Cheers,
John

craftzdog · November 10, 2019, 8:08pm

Hi John,

Thanks for letting me know that!
Yeah, I am actually aware of that but no, it isn’t.
Because Inkdrop’s build process is based on Atom’s and it’s complicated to adopt electron-builder.
Recently, Inkdrop has bumped up Electron from 3.1.4 to 6.0.11 and I guess, perhaps, that would fix some issues on building snap packages.
Here is the snapcraft for Atom which would be helpful to update our repo:

github.com

snapcrafters/atom/blob/master/snap/snapcraft.yaml

name: atom
version: latest
version-script: cat $SNAPCRAFT_STAGE/version
summary: A hackable text editor for the 21st Century.
description: |
  Atom is a free and open source text editor that is modern,
  approachable, and hackable to the core.

grade: stable
confinement: classic

architectures:
  - build-on: amd64

parts:
  gnome:
    plugin: nil
    build-packages:
      - software-properties-common
    override-pull: |

This file has been truncated. show original

It is still too hard to maintain it alone as snapcraft’s build process takes long time.
So, I would appreciate your help so much!

John_Ferlito · December 1, 2019, 5:17am

I’ve created a pull request with some config changes that work for me https://github.com/inkdropapp/inkdrop-snapcraft/pull/2

craftzdog · December 2, 2019, 1:50am

Hi @John_Ferlito

Cool!!! Thank you so much for your effort. I’ll try it!

craftzdog · December 2, 2019, 5:10am

@John_Ferlito

I successfully built the package with your snap config but the automate review failed with the following errors:

> sudo snap install review-tools
> snap-review inkdrop_4.4.0_amd64.snap

Errors
------
 - security-snap-v2:squashfs_files
        found errors in file output: unusual mode 'rwsr-xr-x' for entry './usr/lib/inkdrop/chrome-sandbox'
 - security-snap-v2:squashfs_repack_checksum
        checksums do not match. Please ensure the snap is created with either 'snapcraft pack <DIR>' (using snapcraft >= 2.38) or 'mksquashfs <dir> <snap> -noappend -comp xz -all-
root -no-xattrs -no-fragments'. If using electron-builder, please upgrade to latest stable (>= 20.14.7). See https://forum.snapcraft.io/t/automated-reviews-and-snapcraft-2-38/498$
/17 for details.
        https://forum.snapcraft.io/t/automated-reviews-and-snapcraft-2-38/4982/17
inkdrop_4.4.0_amd64.snap: FAIL

It works fine for running it in local but I can’t publish it.
The most weird error is ‘checksum do not match’.

John_Ferlito · December 2, 2019, 5:39am

I’ll check it out tonight

craftzdog · December 2, 2019, 6:05am

This patch solved the above issue!

It just excludes chrome-sandbox file from the package.
Now we finally have the latest snap package. Could you try it?

sudo snap install --edge inkdrop
sudo snap connect inkdrop:password-manager-service

Thanks again!

craftzdog · December 6, 2019, 5:33am

Promoted it to stable.
Now you can install it with the following commands:

sudo snap install --edge inkdrop
sudo snap connect inkdrop:password-manager-service

Please let me know if it works well or not on your environment.